Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Generated Classes for TextAlignmentExtensions for .NET MAUI Controls internal #161

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Dec 6, 2022

Description of Change

This PR mirrors the similar recently merged PR in CommunityToolkit.Maui, CommunityToolkit/Maui#791

  • Adds the Unit Tests added in Make TextColorTo Generated Classes for .NET MAUI Controls Internal Maui#791
  • Changes the default class accessor for code generated
    • .NET MAUI Controls: internal
    • User Created Controls: Match the provided class accessor
      • E.g. public class MyControl : ITextStyle will generate public static partial class TextAlignmentExtensions_MyControl
      • E.g. internal class MyControl : ITextStyle will generate internal static partial class TextAlignmentExtensions_MyControl

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@brminnick brminnick changed the title Update TextAlignmentExtensionsGenerator Make Generated Classes for TextAlignmentExtensions for .NET MAUI Controls internal Dec 6, 2022
@brminnick brminnick requested a review from pictos December 6, 2022 17:55
pictos
pictos previously approved these changes Dec 6, 2022
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pictos pictos merged commit 3545199 into main Dec 6, 2022
@pictos pictos deleted the Add-TextAlignment-Unit-Tests branch December 6, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants