Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IPlaceholder Extensions #44

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Apr 3, 2022

Description of Change

This PR implements the following fluent extension methods for IPlaceholder:

public static TBindable PlaceholderColor<TBindable>(this TBindable bindable, Color? textColor) where TBindable : BindableObject, IPlaceholder;
public static TBindable Placeholder<TBindable>(this TBindable bindable, string? text) where TBindable : BindableObject, IPlaceholder;
public static TBindable Placeholder<TBindable>(this TBindable bindable, string? text, Color? textColor) where TBindable : BindableObject, IPlaceholder;

Linked Issues

PR Checklist

Additional information

This PR also adds the .Placeholder() to the sample app and includes Unit Tests for the new IPlaceholder extension methods.

This PR also updates the README, adding the workflow image to match the README in CommunityToolkit/Maui.

@brminnick brminnick added do not merge Do not merge this PR pending documentation This feature requires documentation labels Apr 3, 2022
@brminnick brminnick requested a review from pictos April 3, 2022 20:48
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brminnick brminnick added approved documentation approved and removed do not merge Do not merge this PR pending documentation This feature requires documentation labels Apr 3, 2022
@brminnick brminnick merged commit 955afd6 into main Apr 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the Create-PlaceholderExtensions branch April 5, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add IPlaceholder Extension Methods
2 participants