Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Popup - Size is not respected in Landscape mode on iOS #843

Closed
1 task done
Eltee-Taiwo opened this issue Dec 24, 2022 · 4 comments · Fixed by #1320
Closed
1 task done

[BUG] Popup - Size is not respected in Landscape mode on iOS #843

Eltee-Taiwo opened this issue Dec 24, 2022 · 4 comments · Fixed by #1320
Labels
bug Something isn't working unverified

Comments

@Eltee-Taiwo
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The Size property of a Popup is not respected when using an iOS device in Landscape mode and popups always take up the full size of the screen.

Expected Behavior

The Size property should be respected and popups should be sizeable rather than full screen when using iOS in Landscape mode.

Steps To Reproduce

  1. Open and run solution
  2. Click button to display popup
  3. Notice size is respected.
  4. Close Popup
  5. Switch to landscape mode
  6. Click button to display popup
  7. Popup uses full screen

Link to public reproduction project repository

https://github.com/jfversluis/MauiToolkitPopupSample

Environment

- .NET MAUI CommunityToolkit: 1.3.0
- OS: Windows 10 + Ventura 13 (M1)
- .NET MAUI: 6

Anything else?

image
image

@Eltee-Taiwo Eltee-Taiwo added bug Something isn't working unverified labels Dec 24, 2022
@brminnick
Copy link
Collaborator

Fixed in #1320

@VNGames
Copy link

VNGames commented Dec 17, 2023

@brminnick It isn't fixed.
Opened a new bug
#1604

@jfversluis
Copy link
Member

jfversluis commented Dec 20, 2023

Seems that might not have been fixed yet, let's reopen to have another look

@jfversluis jfversluis reopened this Dec 20, 2023
@vhugogarcia
Copy link
Contributor

This issue has been fixed. I tested it using the latest version. Please find attached screenshots of the popup maintaining the position when rotate the device. For the reason mentioned previously, I'm closing this issue.

Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 42 12
Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 42 07
Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 41 57
Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 41 48
Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 41 10
Simulator Screenshot - iPhone 15 - 2024-06-21 at 10 41 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unverified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants