-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic OrderView #1011
Semantic OrderView #1011
Conversation
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.ios.cs
Outdated
Show resolved
Hide resolved
samples/CommunityToolkit.Maui.Sample/Pages/Views/SemanticOrderView/SemanticOrderViewPage.xaml
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Handlers/SemanticOrderView/SemanticOrderViewHandler.shared.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.ios.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.ios.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.windows.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui/Views/SemanticOrderView/SemanticOrderView.shared.cs
Outdated
Show resolved
Hide resolved
the windows build failed but I don't know where/why/how it failed. |
@PureWeen your branch is up to date with |
src/CommunityToolkit.Maui.Core/Views/SemanticOrderView/MauiSemanticOrderView.ios.cs
Outdated
Show resolved
Hide resolved
Tizen build fails.
|
🤞 |
Sorry for the Tizen workload issue. Looks like it is ok now :) |
src/CommunityToolkit.Maui.Core/Handlers/SemanticOrderView/SemanticOrderViewHandler.tizen.cs
Outdated
Show resolved
Hide resolved
Thanks @PureWeen! Are you able to submit a PR to our docs repo today? We are releasing v5.0.0 tomorrow, and I'd love to include this in the release! But we can't merge it until we have a Docs PR opened: https://github.com/MicrosoftDocs/CommunityToolkit/pull/ @bijington or @pictos - are you by chance available to help with the docs? Adding
do not merge
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shane!
I'd love a quick update to the Sample App page to provide more context and guide the user on what they are learning/experiencing by visiting this page in the sample app.
I'm also curious why CommunityToolkit.Maui.Views.SemanticOrderView.ViewOrder
is using IEnumerable
instead of IEnumerable<View>
or IEnumerable<IView>
?
samples/CommunityToolkit.Maui.Sample/Pages/Views/SemanticOrderView/SemanticOrderViewPage.xaml
Show resolved
Hide resolved
...les/CommunityToolkit.Maui.Sample/Pages/Views/SemanticOrderView/SemanticOrderViewPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui/Views/SemanticOrderView/SemanticOrderView.shared.cs
Outdated
Show resolved
Hide resolved
I'm on the docs case right now! |
Thank you for finishing this one up! !!!! Thank You !!!! |
Description of Change
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information