Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic OrderView #1011

Merged
merged 27 commits into from
Feb 28, 2023
Merged

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Feb 19, 2023

Description of Change

Linked Issues

PR Checklist

Additional information

@PureWeen PureWeen requested review from pictos and VladislavAntonyuk and removed request for pictos February 19, 2023 19:59
@PureWeen
Copy link
Contributor Author

@pictos @VladislavAntonyuk

the windows build failed but I don't know where/why/how it failed.
I don't have access to the CI pipeline either

@PureWeen PureWeen requested review from pictos and VladislavAntonyuk and removed request for VladislavAntonyuk and pictos February 19, 2023 20:00
@pictos
Copy link
Member

pictos commented Feb 19, 2023

@PureWeen your branch is up to date with main? That was because our CI didn't found the tizen workload, but that should be solved already at main branch

@VladislavAntonyuk
Copy link
Collaborator

VladislavAntonyuk commented Feb 19, 2023

Tizen build fails.

D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(9,22): error CS0263: Partial declarations of 'SemanticOrderViewHandler' must not specify different base classes [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]
D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(14,78): error CS0311: The type 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' cannot be used as type parameter 'TViewHandler' in the generic type or method 'IPropertyMapper<TVirtualView, TViewHandler>'. There is no implicit reference conversion from 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' to 'Microsoft.Maui.IElementHandler'. [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]
D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(21,76): error CS0311: The type 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' cannot be used as type parameter 'TViewHandler' in the generic type or method 'CommandMapper<TVirtualView, TViewHandler>'. There is no implicit reference conversion from 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' to 'Microsoft.Maui.IElementHandler'. [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]

@PureWeen
Copy link
Contributor Author

Tizen build fails.

D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(9,22): error CS0263: Partial declarations of 'SemanticOrderViewHandler' must not specify different base classes [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]
D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(14,78): error CS0311: The type 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' cannot be used as type parameter 'TViewHandler' in the generic type or method 'IPropertyMapper<TVirtualView, TViewHandler>'. There is no implicit reference conversion from 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' to 'Microsoft.Maui.IElementHandler'. [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]
D:\a\1\s\src\CommunityToolkit.Maui.Core\Handlers\SemanticOrderView\SemanticOrderViewHandler.shared.cs(21,76): error CS0311: The type 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' cannot be used as type parameter 'TViewHandler' in the generic type or method 'CommandMapper<TVirtualView, TViewHandler>'. There is no implicit reference conversion from 'CommunityToolkit.Maui.Core.Handlers.SemanticOrderViewHandler' to 'Microsoft.Maui.IElementHandler'. [D:\a\1\s\src\CommunityToolkit.Maui.Core\CommunityToolkit.Maui.Core.csproj::TargetFramework=net7.0-tizen]

🤞

@JoonghyunCho
Copy link
Member

Sorry for the Tizen workload issue. Looks like it is ok now :)

pictos
pictos previously approved these changes Feb 27, 2023
@brminnick brminnick dismissed their stale review February 27, 2023 15:45

Tizen completed

@brminnick
Copy link
Collaborator

brminnick commented Feb 27, 2023

Thanks @PureWeen! Are you able to submit a PR to our docs repo today? We are releasing v5.0.0 tomorrow, and I'd love to include this in the release! But we can't merge it until we have a Docs PR opened: https://github.com/MicrosoftDocs/CommunityToolkit/pull/

@bijington or @pictos - are you by chance available to help with the docs?

Adding do not merge Do not merge this PR and pending documentation This feature requires documentation for now to ensure we don't forget the documentation.

@pictos pictos added the pending documentation This feature requires documentation label Feb 27, 2023
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shane!

I'd love a quick update to the Sample App page to provide more context and guide the user on what they are learning/experiencing by visiting this page in the sample app.

I'm also curious why CommunityToolkit.Maui.Views.SemanticOrderView.ViewOrder is using IEnumerable instead of IEnumerable<View> or IEnumerable<IView>?

@brminnick brminnick added the do not merge Do not merge this PR label Feb 27, 2023
@bijington
Copy link
Contributor

I'm on the docs case right now!

@brminnick brminnick dismissed stale reviews from pictos and jfversluis via 71261e4 February 28, 2023 23:04
@brminnick brminnick added documentation approved and removed pending documentation This feature requires documentation do not merge Do not merge this PR labels Feb 28, 2023
@brminnick brminnick enabled auto-merge (squash) February 28, 2023 23:24
@brminnick brminnick merged commit d3f3159 into CommunityToolkit:main Feb 28, 2023
@PureWeen
Copy link
Contributor Author

PureWeen commented Mar 1, 2023

Thank you for finishing this one up!
I just got back into the office today and just caught up to the requests here.

!!!! Thank You !!!!

@PureWeen PureWeen deleted the semanticorderview branch April 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] SemanticOrderView
7 participants