Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PopupExtensions.shared.cs #1229

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update PopupExtensions.shared.cs #1229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/CommunityToolkit.Maui/Views/Popup/PopupExtensions.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ public static partial class PopupExtensions
}
else
{
void handler(object? sender, NavigatedToEventArgs args)
void handler(object? sender, EventArgs args)
{
page.NavigatedTo -= handler;
page.Loaded -= handler;

CreateAndShowPopup(page, popup);
}

page.NavigatedTo += handler;
page.Loaded += handler;
}
}

Expand All @@ -60,9 +60,9 @@ void handler(object? sender, NavigatedToEventArgs args)
{
var taskCompletionSource = new TaskCompletionSource<object?>();

async void handler(object? sender, NavigatedToEventArgs args)
async void handler(object? sender, EventArgs args)
{
page.NavigatedTo -= handler;
page.Loaded -= handler;

try
{
Expand All @@ -76,7 +76,7 @@ async void handler(object? sender, NavigatedToEventArgs args)
}
}

page.NavigatedTo += handler;
page.Loaded += handler;

return taskCompletionSource.Task;
}
Expand Down