Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved memory performance of TextColorToGenerator #1254

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Improved memory performance of TextColorToGenerator #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99c50b6
Avoiding boxing enumerators of built-in types and also unrolled this …
AllenD-MSFT Jun 15, 2023
5288206
Replaced null check with ‘is’ instead of ‘==‘.
AllenD-MSFT Jun 15, 2023
de36329
Merge branch 'main' into main
brminnick Jun 25, 2023
6832a5e
Merge branch 'main' into main
brminnick Jul 23, 2023
523e235
Merge branch 'main' into main
brminnick Sep 22, 2023
ac0655e
Update azure-pipelines.yml
brminnick Sep 22, 2023
512e9be
Fix Vulnerable Tizen Dependency
brminnick Sep 22, 2023
3c37692
Change `SkiaSharp` -> `SkiaSharp.Views` and move it to `CommunityTool…
brminnick Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ jobs:

# check vulnerabilities
- powershell: |
dotnet list $(PathToLibrarySolution) package --vulnerable --include-transitive | findstr /S /c:"has the following vulnerable packages";
dotnet list $(PathToLibrarySolution) package --include-transitive # Print all transitive packages
dotnet list $(PathToLibrarySolution) package --vulnerable --include-transitive | findstr /S /c:"has the following vulnerable packages"; # Print all transitive packages with vulnerabilities
if ($LastExitCode -ne 1)
{
dotnet list $(PathToLibrarySolution) package --vulnerable --include-transitive;
Expand Down
4 changes: 4 additions & 0 deletions src/CommunityToolkit.Maui.Core/CommunityToolkit.Maui.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
<None Include="ReadMe.txt" pack="true" PackagePath="." />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.Contains('-tizen'))">
<PackageReference Include="SkiaSharp.Views" Version="[2.88.6,)" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1">
<PrivateAssets>all</PrivateAssets>
Expand Down
19 changes: 18 additions & 1 deletion src/CommunityToolkit.Maui.SourceGenerators/Generators/TextColorToGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,24 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
throw new Exception("There's no .NET MAUI referenced in the project.");
}

var mauiAssembly = compilation.SourceModule.ReferencedAssemblySymbols.Single(q => q.Name == mauiControlsAssembly);
var mauiAssembly = default(IAssemblySymbol);
foreach (var assemblySymbol in compilation.SourceModule.ReferencedAssemblySymbols)
{
if (assemblySymbol.Name == mauiControlsAssembly)
{
if (mauiAssembly is not null)
{
throw new InvalidOperationException("There can only be one reference to the Maui Controls assembly.");
}

mauiAssembly = assemblySymbol;
}
}
if (mauiAssembly is null)
{
throw new InvalidOperationException("There is no reference to the Maui Controls assembly.");
}

var symbols = GetMauiInterfaceImplementors(mauiAssembly, iAnimatableInterfaceSymbol, iTextStyleInterfaceSymbol).Where(static x => x is not null);

return symbols;
Expand Down