.NET 8

[VladislavAntonyuk]

Description of Change

Linked Issues

• Fixes [Proposal] .Net 8 Preview (Beta) Nuget  #1284
• Fixes [BUG] Snackbar InvalidOperationException when using dotnet trimmer #1460

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pull/XYZ

Additional information

[brminnick]

@VladislavAntonyuk FYI - the PR we merged today introduced merge conflicts in the csproj files on this PR

[brminnick]

I wonder if we can also remove our reference to the DotNet.ReproducibleBuilds NuGet package now that SourceLink is included in .NET 8: https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8#source-link?

I haven't tried it yet with the toolkit, but it's certainly something we can look into!

[VladislavAntonyuk]

I wonder if we can also remove our reference to the DotNet.ReproducibleBuilds NuGet package now that SourceLink is included in .NET 8: learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8#source-link?

I haven't tried it yet with the toolkit, but it's certainly something we can look into!

removed, let's see how it works. we can always add it if necessary

[brminnick]

Update: @CliffAgius is going to update our documentation on how to consume our preview packages so that community members can use this .NET 8 pre-release of CommunityToolkit.Maui:

1. Update the Wiki
2. Add documentation to the Official Docs: https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/

[inforithmics]

Any plans to include this

#1342 (comment)

.Net Maui has now the possibility to AddLogicalChildren instead of only Setting the Parent.

[ne0rrmatrix]

Media Element issue's and dotnet 8

On IOS the player position is not being reported. Works fine on Windows. Tested on RC2.

Probably the numeric validation bug is the issue here too. I have also noticed some odd behavior with media element with dotnet 8.

It works fine if you use built in controls and do nothing else. Trying to get position in code behind and events are not working properly. They do not fire on Android or IOS. Everything works great on windows though.

edit: This build does work fine in toolkit sample build and appears only to be an issue for my use case. I am having media element events not firing and I am unable to track position of media playback when using custom controls. I will have to investigate further. But media playback with built in controls appears to track playback position just fine. Events for media element are untested except for not explicitly working for me. This is most likely an implementation issue on my end though. It works fine on 7.0x but again I want to reiterate it builds and works fine as part of toolkit.

[ne0rrmatrix]

What is the best practices for reporting issues with this PR? I am having issues with differences in behavior between devices? Should I even mention it? The official samples work as expected when I test the feature I am having issues with. Should I even be commenting with bugs? Or should I wait till its released?

[brminnick]

Thanks Vlad!!

[brminnick]

Thanks @ne0rrmatrix!

Now that we've merged our PR supporting .NET 8, could you test MediaElement again on the main branch and then open an Issue if you confirm the bug still exists?

[ne0rrmatrix]

I tested my use case against main. I am having issues on Android and IOS. Untested on Mac atm. I don't believe the issue is caused by media element itself though. The sample builds fine and works as expected.

I am having issues with being unable to get the position of playback while playing any media. I can get the duration just fine. I am using a content view and have created custom controls. The content view is unable to get the position. It works fine in dotnet 7.x app but as soon as I switch to 8.x it stops working. This does not appear to be an issue for windows at all. It is just mobile devices like android or IOS. Have not tested on mac. It only affects me when using a content view. Directly using media element everything works as expected.

The issue is most likely not directly related to the toolkit. It appears to be an issue with either my code implementation of binding or a bug in Maui itself. I will have to do further testing to figure out where it is the problem originates.