Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8.0 GA #1499

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Update to .NET 8.0 GA #1499

merged 7 commits into from
Nov 14, 2023

Conversation

brminnick
Copy link
Collaborator

Description of Change

This PR updates global.json, azurepipelines.yml and DirectoryBuild.props in anticipation of the upcoming .NET 8.0 GA release;

Additional information

The CI build is expected to fail until the GA release of .NET 8.0

@brminnick brminnick marked this pull request as draft November 5, 2023 22:41
@brminnick brminnick marked this pull request as ready for review November 14, 2023 16:41
@brminnick
Copy link
Collaborator Author

Hey @JoonghyunCho! Can you help us fix the Tizen build error?

C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.128\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net8.0-tizen]
C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.128\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net8.0-tizen is not supported in this api-version. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net8.0-tizen]

https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=100402&view=logs&j=67da6a11-18ef-5f70-9b43-fae7e6c83e18&t=f71eeafc-b93b-5d4c-447b-0401a1900176&l=860

@JoonghyunCho
Copy link
Member

Hey @JoonghyunCho! Can you help us fix the Tizen build error?

C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.128\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net8.0-tizen]
C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.128\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net8.0-tizen is not supported in this api-version. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net8.0-tizen]

https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=100402&view=logs&j=67da6a11-18ef-5f70-9b43-fae7e6c83e18&t=f71eeafc-b93b-5d4c-447b-0401a1900176&l=860

I should have fixed it in advance... finger crossed for the green build now!

@brminnick brminnick merged commit 368f2ce into main Nov 14, 2023
7 checks passed
@brminnick brminnick deleted the Update-to-.NET-8.0-GA branch November 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants