Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully qualified namespace for Colors reference in TextToColorGenerator #1536

Conversation

IIARROWS
Copy link
Contributor

This change should prevent "ambiguous reference" error to occur when other packages are included in a MAUI project that provide their own Color objects.

Examples of such libraries is MudBlazor.

Description of Change

In the source code generator use a fully qualified namespace to the Color object, so Color is changed into global::Microsoft.Maui.Graphics.Colors following the example for the similar solution for of #1331

As per previous PR, no tests added, current tests are sufficient to cover this change (and using the wrong value fail).

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@IIARROWS
Copy link
Contributor Author

@dotnet-policy-service agree

@brminnick brminnick enabled auto-merge (squash) November 18, 2023 19:22
@brminnick brminnick merged commit 8b62999 into CommunityToolkit:main Nov 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ambiguous reference error occurs when other package is included that provides its own Colors object
2 participants