Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Windows] UniformItemsLayout item positioning not correct #1553 #1566

Merged
merged 2 commits into from
Nov 26, 2023
Merged

[BUG] [Windows] UniformItemsLayout item positioning not correct #1553 #1566

merged 2 commits into from
Nov 26, 2023

Conversation

VladislavAntonyuk
Copy link
Collaborator

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

image

@VladislavAntonyuk VladislavAntonyuk requested a review from a team November 26, 2023 13:50
@VladislavAntonyuk VladislavAntonyuk self-assigned this Nov 26, 2023
@VladislavAntonyuk VladislavAntonyuk marked this pull request as ready for review November 26, 2023 13:58
brminnick
brminnick approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vlad! Just a quick question for ya! (See review comment)

src/CommunityToolkit.Maui.Core/Layouts/UniformItemsLayoutManager.shared.cs Show resolved Hide resolved
@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) November 26, 2023 19:32
@VladislavAntonyuk VladislavAntonyuk merged commit 7160815 into main Nov 26, 2023
7 checks passed
@VladislavAntonyuk VladislavAntonyuk deleted the 1553-uniformitemslayout-fix-size branch November 26, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick approved these changes

Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [Windows] UniformItemsLayout item positioning not correct
2 participants
@VladislavAntonyuk @brminnick