Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HLS URL #1571

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Change HLS URL #1571

merged 2 commits into from
Nov 27, 2023

Conversation

ne0rrmatrix
Copy link
Contributor

  • Bug fix

Description of Change

Change Media Element URL for HLS stream in Sample app

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

This PR will fix Media Element URL cannot be resolved in all devices for HLS stream in Sample app.

jfversluis
jfversluis approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh thanks! We should have a URL we can control some how ideally I guess but this work for now. Thank you!

@jfversluis jfversluis merged commit a7944c1 into CommunityToolkit:main Nov 27, 2023
8 checks passed
@jfversluis jfversluis added the 📽️ MediaElement Issue/PR that has to do with MediaElement label Nov 27, 2023
@ne0rrmatrix ne0rrmatrix deleted the HLSSampleFix branch February 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfversluis jfversluis jfversluis approved these changes

Assignees
No one assigned
Labels
📽️ MediaElement Issue/PR that has to do with MediaElement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HLS stream cannot be resolved in Sample app
2 participants
@ne0rrmatrix @jfversluis