Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android File Saver - remove MemoryStream #1637

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Android File Saver - remove MemoryStream #1637

merged 3 commits into from
Feb 1, 2024

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Jan 5, 2024 •
edited
Loading

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@VladislavAntonyuk VladislavAntonyuk self-assigned this Jan 5, 2024
@VladislavAntonyuk VladislavAntonyuk requested a review from a team January 5, 2024 21:16
@VladislavAntonyuk VladislavAntonyuk force-pushed the bugfix/android-file-saver branch 2 times, most recently from 1a3894c to 55cbf84 Compare January 5, 2024 21:19
bijington
bijington approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a minor question that likely just helps me understand something better :)

src/CommunityToolkit.Maui.Core/Essentials/FileSaver/FileSaverImplementation.android.cs Show resolved Hide resolved
pictos
pictos approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just double checking, did you try to save a large file?

@VladislavAntonyuk
Copy link
Collaborator Author

it was verified with a 1 GB file on the emulator with 1 GB RAM. https://downloadtestfile.com/

@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) January 21, 2024 13:08
@VladislavAntonyuk VladislavAntonyuk merged commit 56fe311 into main Feb 1, 2024
7 checks passed
@VladislavAntonyuk VladislavAntonyuk deleted the bugfix/android-file-saver branch February 1, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bijington bijington bijington approved these changes

@pictos pictos pictos approved these changes

Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to Save Multi GB Files using FileSaver on Android
3 participants
@VladislavAntonyuk @bijington @pictos