New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add popup size update on iOS #1653
Conversation
As an aside, I tried updating the View's Bounds within the method below, but it didn't work as intended. [src\CommunityToolkit.Maui.Core\Handlers\Popup\PopupHandler.macios.cs]
[src\CommunityToolkit.Maui.Core\Views\Popup\PopupExtensions.macios.cs]
The update within the ViewWillTransitionToSize method worked as intended. |
@bijington , I left a comment that updating the View's Bounds works as intended with the ViewWillTransitionToSize method, not the MapSize, SetSize methods. |
Can we get this merged please? It's been 2 months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kenji!!
This PR resolves the issue where Gestures do not work on Popups when changing the Popup's Size property.
Description of Change
Bounds of a UIView placed in a Popup will not be updated after calling the SetView method.
[src\CommunityToolkit.Maui.Core\Views\Popup\MauiPopup.macios.cs]
Therefore, update the View's Bounds in the method below that is called when the View's size is updated.
[src\CommunityToolkit.Maui.Core\Views\Popup\MauiPopup.macios.cs]
This will update the View's Bounds and allow the Gesture to work even after the size update.
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information
Below is the verification video.
I used the issue reproduction code for verification.
iPhone.15.iOS.17.0.2024-01-19.15-35-07.mp4
You can see that the Gesture is still working after updating the Popup's size.