-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning #1675
Conversation
…t as FabricBot replacement Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service.
@jfversluis / @kphillpotts - any idea what this is? Is this a new MSFT policy required for using the bot? |
@brminnick FabricBot is going away, this is probably the new thing. Do we actually use those automations a whole lot here? If we do, we will want to merge this, if we don't we might chose to just unboard ourselves? |
Haha- yup, tons of automations. FabricBot is the msftbot. Every time you see the msftbot add a label, comment on an issue, etc., I programmed that with FabricBot.
Wow, this is going to completely break the workflow automations I created. Can you link me to documentation or connect me with anyone where I can understand more about this? This is a huge breaking change for our repo. For example, the new |
I can't appear to CC them here, but along with myself, Jeff Handley & Johannes Lampel have been on point for the fabricbot migration. Unfortunately project board automation is not supported in the new PolicyBot - their recommendation to us in the dotnet org has been to use the new built-in automation that's part of the new-style project boards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the project board issue, the migration itself doesn't appear to have any of the known bugs.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Add Proposal to Project Board", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Add Champion Label", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Add Approved Label", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Add Pending Documentation Label", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Add Documentation Approved Label", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Reopen Closed Proposals Not In Closed Column", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
"issues", | ||
"project_card" | ||
], | ||
"taskName": "Automatically Close Proposals when Added to `Completed` or `Closed`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project board automation is not supported in the new service, so related tasks were not ported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brminnick I concur with @wtgodbe's comment that the project board automation doesn't carry over but the other config correctly got ported.
I know you had a lot of project board automation in place here that will be annoying to lose, without a clear approach for replicating that even with GitHub's built-in automation. It could be implemented using GitHub Actions, but it would take some work.
This PR should get merged to retain the other functionality though. And CommunityToolkit/.github#5 also needs to be merged to get the new service added into the CLA bypass list.
/cc @JohannesLampel
Thank you, I understand. I am blocked from merging this until I can carve out the time to first migrate our project board. This is a massive breaking change to the organization and workflow of the .NET MAUI Community Toolkit. |
@brminnick I just wanted to let you know that we will need to turn off the old system by the end of the month. So at least merging what this config to preserve the rest of the functionality might be a good idea. I am also happy to assist with anything fabricBot/ResourceManagement related in case there are any problems. |
Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement
Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html
Please review and merge this PR to complete the process of onboarding to the new service.