Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with tinted image size being set incorrectly on Windows. #1685

Merged
merged 11 commits into from
Feb 17, 2024

Conversation

StevilKnevil
Copy link
Contributor

@StevilKnevil StevilKnevil commented Feb 8, 2024

Description of Change

Tinted images now have their base images set to transparent rather than zero size.

I have been unable to add a unit test for this as I cannot work out how to trigger an update of the tint colour in the context of a test.

Linked Issues

PR Checklist

@StevilKnevil StevilKnevil marked this pull request as draft February 8, 2024 22:48
@StevilKnevil
Copy link
Contributor Author

@dotnet-policy-service agree [company="{your company}"]

@dotnet-policy-service agree

@StevilKnevil StevilKnevil marked this pull request as ready for review February 9, 2024 11:01
@bijington
Copy link
Contributor

I think we have some versioning issues which a current PR I hoping to fix. Then the checks might be happy again

@StevilKnevil StevilKnevil changed the title Fixed issue with tinted image size being set incorrectly. Fixed issue with tinted image size being set incorrectly on Windows. Feb 15, 2024
StevilKnevil and others added 2 commits February 17, 2024 09:47
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StevilKnevil!

@brminnick brminnick enabled auto-merge (squash) February 17, 2024 20:08
@brminnick brminnick merged commit a2b6a2d into CommunityToolkit:main Feb 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants