Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Handler disconnect on Unloaded event #1691

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Add missing Handler disconnect on Unloaded event #1691

merged 6 commits into from
Feb 15, 2024

Conversation

ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix commented Feb 13, 2024 •
edited

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Add missing disconnect handler for media element to page unloaded event.

@ne0rrmatrix ne0rrmatrix marked this pull request as ready for review February 13, 2024 17:07
brminnick
brminnick approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ne0rrmatrix!

@brminnick brminnick enabled auto-merge (squash) February 15, 2024 21:32
@brminnick brminnick merged commit 9c83cd4 into CommunityToolkit:main Feb 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Media Element Sample missing handler disconnect
3 participants
@ne0rrmatrix @brminnick @pictos