Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old code to set the status bar behavior values #1713

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

bijington
Copy link
Contributor

This might not be completely necessary as it doesn't currently conflicting with our samples page but... the code removed here does conflict if a developer opts for just providing a value into the StatusBarBehavior (e.g.

<Page.Behaviors>
        <mct:StatusBarBehavior
              StatusBarColor="Red"
              StatusBarStyle="{Binding Source={x:Reference Page}, Path=BindingContext.StatusBarStyle}" />
 </Page.Behaviors>

The resulting behaviour will be that no Color will exist and the status bar (at least on iOS) will be Black.

@bijington bijington requested a review from a team February 25, 2024 14:10
@jfversluis jfversluis merged commit 739c843 into main Feb 26, 2024
8 checks passed
@jfversluis jfversluis deleted the feature/sl-remove-conflicting-statusbar-code branch February 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants