Fixes #1702: Fixed Memory Leak in MediaElement #1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed Memory Leak in MediaElement.
The timer is now disposed as well.
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information
Tested on:
WinUI
,Android
,iOS
My Issues hasn't been approved yet, but I thought I nevertheless share my findings with this PR.
I hope you can merge it, in order to improve memory management for people using the
MediaElement
.P.S.:
As mentioned in the Issue, besides disposing the handler, I had to dispose the
MediaElement
itself as well to get rid of the Memory Leak:But I think this can be added to the docu+sample later on...
Many thanks!