Fix Back button behavior when Media Element is full screen #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DetachedFromWindow` to the `MauiMediaElement` class. This method ensures that when the view is detached from the window, if the media element is in full screen mode, it will exit full screen mode and stop the player. Changes: - Added an override method `OnDetachedFromWindow` to the `MauiMediaElement` class. This method is called when the view is detached from a window. It first calls the base class's `OnDetachedFromWindow` method. - Inside the `OnDetachedFromWindow` method, it checks if the media element is in full screen mode. If it is, it triggers the `OnFullscreenButtonClick` event with the argument set to the opposite of `isFullScreen`, and stops the player. This ensures that when the view is detached from the window, if the media element is in full screen mode, it will exit full screen mode and stop the player.
…n the `MauiMediaElement` class. The player will no longer stop if the view is in full screen mode when detached from the window. Changes: - The `OnDetachedFromWindow` method in the `MauiMediaElement` class has been altered. The code that stopped the player when the view was in full screen mode and detached from the window has been removed. The call to the base class's `OnDetachedFromWindow` method is still present. (Reference: `MauiMediaElement` class, `OnDetachedFromWindow` method)
…m/ne0rrmatrix/MauiOld into FixMediaElementBackButtonBehavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding an override method
OnDetachedFromWindowto theMauiMediaElementclass. This method ensures that when the view is detached from the window, if the media element is in full screen mode, it will exit full screen mode.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Changes:
OnDetachedFromWindowto theMauiMediaElementclass. This method is called when the view is detached from a window. It first calls the base class'sOnDetachedFromWindowmethod.OnDetachedFromWindowmethod, it checks if the media element is in full screen mode. If it is, it triggers theOnFullscreenButtonClickevent with the argument set to the opposite ofisFullScreen, and stops the player. This ensures that when the view is detached from the window, if the media element is in full screen mode, it will exit full screen mode.