Update Touch Behavior Sample #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axemasta
force-pushed
the
touch-behavior-sample
branch
from
6527ab9
to
3daad92
Compare
The sample now shows the recommended way to set the binding context for the touch behavior
Ran dotnet format on the solution, looks like its touch behaviour stuff that needed the formats!
There is now an example of the touch behavior being used to pass a command parameter
Seperate the sections out into more clearly seperated segments for visual clarity
This change set got quite messy when rebasing so I've now resolved everything by hand
Axemasta
force-pushed
the
touch-behavior-sample
branch
2 times, most recently
from
e17e29d
to
977dd34
Compare
Somehow managed to remove this... 🙈
Axemasta
force-pushed
the
touch-behavior-sample
branch
from
977dd34
to
dcec6ff
Compare
|
@brminnick I've pushed a fix & rebased ontop of main 👍 |
brminnick
approved these changes
Apr 28, 2024
|
Wonderful! Thank you sir 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the
TouchBehaviorsample gallery to show the recommended method of setting of setting the binding context for theTouchBehavior.I have included a new usage with the
CommandParameterto help clearup some confusion we've been seeing for people consuming thisBehaviorupon release.Linked Issues
N/A
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRDocs PR
Additional information
I've run
dotnet formatand checked that in, some minor changes all in theTouchBehaviorarea.Screenshots of changes to the sample:
