Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Map control no longer displays the User's Location Pin after adding a Pin to the Map when IsShowingUser is set to True #1801 #1817

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

mikelor
Copy link
Contributor

@mikelor mikelor commented Apr 15, 2024

  • Fix

Description of Change

Modified removeAllPins() script function to add back locationPin if it is not null.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

  • First Community Pull Request - Please be gentle. :)
  • Modified sample to set IsShowingUser="True"
  • Test on Windows 11 Pro

…Pins Page sample show user. Updated MapHandler.Windows RemoveAllPins() to add back user location if showing user.
@mikelor
Copy link
Contributor Author

mikelor commented Apr 15, 2024

@dotnet-policy-service agree

@mikelor mikelor marked this pull request as ready for review April 15, 2024 20:05
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikelor!

@brminnick brminnick enabled auto-merge (squash) April 27, 2024 22:42
@brminnick brminnick merged commit 5934abf into CommunityToolkit:main Apr 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants