Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem that ErrorCode always overwritten by ErrorCodeName. (Android) #1827

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Fix problem that ErrorCode always overwritten by ErrorCodeName. (Android) #1827

merged 4 commits into from
Apr 27, 2024

Conversation

tsanie
Copy link
Contributor

@tsanie tsanie commented Apr 19, 2024

Description of Change

Fix an issue that MediaManager user platform Android cannot get ErrorCode (always overwritten by ErrorCodeName).

Linked Issues

  • None

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@tsanie
Copy link
Contributor Author

tsanie commented Apr 19, 2024

@dotnet-policy-service agree

brminnick
brminnick previously approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @tsanie!!

@brminnick brminnick enabled auto-merge (squash) April 27, 2024 21:00
@brminnick brminnick merged commit 72837bf into CommunityToolkit:main Apr 27, 2024
7 checks passed
@tsanie tsanie deleted the fix-media-manager-error-message branch April 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsanie @brminnick