-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed sample application crashed with MediaElement for Windows #1870
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj
Outdated
Show resolved
Hide resolved
Adding the Do not merge this PR until Microsoft.Maui.Controls v8.0.21 is included in the Visual Studio (stable) release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the templates for the current release of Visual Studio (stable) are using Microsoft.Maui.Controls v8.0.21
Dang - in |
I was able to use reflection as a workaround. The root cause of this bug fix is that .NET MAUI is now using partial classes for |
Ok - there's one more bug we need to fix with the AppTheme test now. I just spent the last few hours digging into it and couldn't figure it out. @olekssokol any chance you could take a look? |
Yes, of course, I'll take a look at it |
Sample application crashed in MediaElement page when the "Tab" key switches the active state to the "Change Aspect" button, and then the "Space" key executes it.
In this case, the problem is due to the DisplayActionSheet call from the Microsoft.Maui.Controls package, it should display the window and return the pressed button, but instead of the window, it immediately returns null, which was not handled in the Sample project.