-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project reorganization #214
Conversation
...Toolkit.Maui.Controls/src/CommunityToolkit.Maui.Controls/Alerts/Snackbar/Snackbar.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Controls/src/CommunityToolkit.Maui.Controls/AppBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...olkit.Maui.Controls/src/CommunityToolkit.Maui.Controls/CommunityToolkit.Maui.Controls.csproj
Outdated
Show resolved
Hide resolved
...ontrols/src/CommunityToolkit.Maui.Controls/Extensions/MultiValueConverterExtension.shared.cs
Outdated
Show resolved
Hide resolved
I approve this PR. |
390ce61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with Vlad's recommendations 👍
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again with updates for .NET MAUI Preview 11
(The .NET MAUI team moved System.nfloat
to ObjCRuntime.nfloat
🤷♂️)
Dang. Preview 11 broke the Unit Tests too. I'll circle back to this tomorrow when (hopefully) all of the Preview 11 workloads have been pushed to the public NuGet feeds 👍 |
Exactly what I told yesterday 😄 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again after updating the unit test suite for .NET MAUI Preview 11
Fixes #213
Description
This is a housekeeping task, where we will change the project structure to mimic the .NET MAUI structure.
Detailed Solution
Split the old implementation into two new projects.
I just move all code and change some namespaces, all features and bugs should be the same as
main
branch