Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project reorganization #214

Merged
merged 68 commits into from
Dec 14, 2021
Merged

Project reorganization #214

merged 68 commits into from
Dec 14, 2021

Conversation

pictos
Copy link
Member

@pictos pictos commented Dec 8, 2021

Fixes #213

Description

This is a housekeeping task, where we will change the project structure to mimic the .NET MAUI structure.

Detailed Solution

Split the old implementation into two new projects.

I just move all code and change some namespaces, all features and bugs should be the same as main branch

@pictos pictos self-assigned this Dec 8, 2021
@pictos pictos added the ♻ housekeeping This issue/PR is related to internal stuff. label Dec 8, 2021
@pictos
Copy link
Member Author

pictos commented Dec 14, 2021

I approve this PR.

@brminnick brminnick dismissed stale reviews from VladislavAntonyuk and themself via 390ce61 December 14, 2021 00:38
brminnick
brminnick previously approved these changes Dec 14, 2021
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with Vlad's recommendations 👍

@brminnick brminnick enabled auto-merge (squash) December 14, 2021 00:41
@brminnick
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brminnick
Copy link
Collaborator

brminnick commented Dec 14, 2021

Shoot - it looks like dotnet workload install maui now installs Preview 11 (must've just been released), which is now breaking the build.

I'm on it 👍

image

brminnick
brminnick previously approved these changes Dec 14, 2021
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again with updates for .NET MAUI Preview 11

(The .NET MAUI team moved System.nfloat to ObjCRuntime.nfloat 🤷‍♂️)

@brminnick
Copy link
Collaborator

Dang. Preview 11 broke the Unit Tests too.

I'll circle back to this tomorrow when (hopefully) all of the Preview 11 workloads have been pushed to the public NuGet feeds 👍

@VladislavAntonyuk
Copy link
Collaborator

Approving again with updates for .NET MAUI Preview 11

(The .NET MAUI team moved System.nfloat to ObjCRuntime.nfloat 🤷‍♂️)

Exactly what I told yesterday 😄 .

brminnick
brminnick previously approved these changes Dec 14, 2021
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after updating the unit test suite for .NET MAUI Preview 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻ housekeeping This issue/PR is related to internal stuff.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Project Reorganization
4 participants