Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the xmlns typo #263

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Corrected the xmlns typo #263

merged 3 commits into from
Feb 1, 2022

Conversation

bijington
Copy link
Contributor

@bijington bijington commented Jan 27, 2022

Description of Change

This PR corrects a typo in the xmlns definition added.

tookit becomes toolkit

Linked Issues

PR Checklist

Additional information

@bijington
Copy link
Contributor Author

The typo has been fixed and there is currently some discussion around introducing an XmlnsPrefix. It is considered good practice to include it even it is matches the current default.

There are current questions over whether toolkit is too long. I quite like it but I appreciate there isn't much context on which toolkit is being used. Some options are:

toolkit - current

mct - MAUI Community Toolkit

ctm - CommunityToolkit.Maui

@VladislavAntonyuk
Copy link
Collaborator

VladislavAntonyuk commented Jan 27, 2022

I like mct. I think it is unique, so we unlikely have conflicts with possible different toolkits

@bijington bijington mentioned this pull request Jan 27, 2022
10 tasks
@egvijayanand
Copy link

My suggestion would also be to go with mct as it sounds similar to the existing xct package and .NET MAUI itself is an evolution of Xamarin.Forms and many existing developers would feel at home.

Regards,
Vijay Anand E G

@bijington
Copy link
Contributor Author

I agree to liking mct also

@bijington
Copy link
Contributor Author

To the reviewer, I haven't been able to test the code action use of the new mct XmlnsPrefix as Visual Studio on my machine is refusing to offer any suggestions in XAML right now.

@pictos
Copy link
Member

pictos commented Jan 27, 2022

@bijington I can try on my end. What's the expected behavior for XmlnsPrefix?

@bijington
Copy link
Contributor Author

@bijington I can try on my end. What's the expected behavior for XmlnsPrefix?

Great thank you. I expect that if you add something from the toolkit in XAML then the code action fix will add the namespace to the root of the element and it would set this:

xmlns:mct="http://schemas.microsoft.com/dotnet/2022/maui/toolkit"

Where it used to set:

xmlns:toolkit="http://schemas.microsoft.com/dotnet/2022/maui/toolkit"

@pictos
Copy link
Member

pictos commented Jan 27, 2022

Looks like the intellisense isn't working for me as well. Should be a xaml editor bug

@bijington
Copy link
Contributor Author

Looks like the intellisense isn't working for me as well. Should be a xaml editor bug

😭

@bijington bijington marked this pull request as ready for review January 30, 2022 09:42
@bijington
Copy link
Contributor Author

Still short of testing how the prefix attribute works works I believe this change is ready

@brminnick brminnick merged commit a62ca26 into main Feb 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/fix-xmlns-typo branch February 1, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Xmlns includes a typo
5 participants