-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the xmlns typo #263
Conversation
The typo has been fixed and there is currently some discussion around introducing an There are current questions over whether
|
I like mct. I think it is unique, so we unlikely have conflicts with possible different toolkits |
My suggestion would also be to go with Regards, |
I agree to liking |
To the reviewer, I haven't been able to test the code action use of the new |
@bijington I can try on my end. What's the expected behavior for |
Great thank you. I expect that if you add something from the toolkit in XAML then the code action fix will add the namespace to the root of the element and it would set this:
Where it used to set:
|
Looks like the intellisense isn't working for me as well. Should be a xaml editor bug |
😭 |
Still short of testing how the prefix attribute works works I believe this change is ready |
Description of Change
This PR corrects a typo in the xmlns definition added.
tookit
becomestoolkit
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information