Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap to using IValueConverter for the EventToCommandBehavior #665

Merged
merged 3 commits into from Oct 1, 2022
Merged

Swap to using IValueConverter for the EventToCommandBehavior #665

merged 3 commits into from Oct 1, 2022

Conversation

bijington
Copy link
Contributor

@bijington bijington commented Sep 30, 2022 •
edited

Description of Change

Removes the requirement for consumers of the EventToCommandBehavior to have to supply an ICommunityToolkitValueConverter and instead relies on the underlying type of IValueConverter that ships with .NET MAUI.

Linked Issues

PR Checklist

Additional information

@VladislavAntonyuk
Copy link
Collaborator

Let's merge it tomorrow! It will be the first PR of Hacktoberfest 2022!

@bijington bijington merged commit b4b9a9f into main Oct 1, 2022
@bijington bijington deleted the issue-569-reduce-expected-converter-base-type branch October 1, 2022 19:23
@brminnick brminnick added this to the v1.4.0 milestone Nov 3, 2022
@mrlacey mrlacey mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick approved these changes

@VladislavAntonyuk VladislavAntonyuk VladislavAntonyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

[Bug] EventToCommandBehavior does not pass EventArgs to command.
3 participants
@bijington @VladislavAntonyuk @brminnick