Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor sample tweaks #209

Merged
merged 6 commits into from Sep 1, 2023
Merged

Minor sample tweaks #209

merged 6 commits into from Sep 1, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Sep 1, 2023 •
edited

Some minor improvements to:

  • Make XAML less verbose (e.g. using our IconExtensions)
  • Minor improvements here and there

Arlodotexe
Arlodotexe approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise welcome improvements!

components/Animations/samples/Animations.Samples.csproj Outdated Show resolved Hide resolved
@niels9001 @Arlodotexe
Update components/Animations/samples/Animations.Samples.csproj
b1da481 
Co-authored-by: Arlo <arlo.godfrey@outlook.com>
@Arlodotexe Arlodotexe merged commit 7158755 into main Sep 1, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/minor-sample-tweaks branch September 1, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niels9001 @Arlodotexe