Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExpressionFunctions.ColorLerpRgb #304

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fix ExpressionFunctions.ColorLerpRgb #304

merged 3 commits into from
Jan 9, 2024

Conversation

h82258652
Copy link
Contributor

Fixes

#303

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The app will be crashed if the code uses ExpressionFunctions.ColorLerpRgb.

What is the new behavior?

The app won't be crashed and the animation works as expected.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@h82258652 h82258652 changed the title init commit Fix ExpressionFunctions.ColorLerpRgb Dec 19, 2023
@Arlodotexe Arlodotexe self-requested a review January 5, 2024 03:43
@Arlodotexe Arlodotexe added bug Something isn't working low difficulty A small or trivial change that isn't difficult to complete. labels Jan 9, 2024
@michael-hawker michael-hawker mentioned this pull request Jan 9, 2024
Merged
Arlodotexe
Arlodotexe approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some unit tests to confirm that the original code was bugged, and this change fixes it. Looks good, thank you!

@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 9, 2024 19:33
@Arlodotexe Arlodotexe merged commit e33f6dd into CommunityToolkit:main Jan 9, 2024
9 checks passed
@lindexi
Copy link

lindexi commented Jan 10, 2024

Awesome

This was referenced Jan 23, 2024
Closed
Closed
@Arlodotexe Arlodotexe self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@michael-hawker michael-hawker michael-hawker left review comments

Assignees

@Arlodotexe Arlodotexe

Labels
bug Something isn't working low difficulty A small or trivial change that isn't difficult to complete. Priority-1
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h82258652 @lindexi @Arlodotexe @michael-hawker