code styling and perf improvement

CommunityToolkit · Oct 7, 2020 · b601e57 · b601e57
1 parent fe1f18a
commit b601e57
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/Microsoft.Toolkit/Collections/ObservableGroup.cs b/Microsoft.Toolkit/Collections/ObservableGroup.cs
@@ -19,7 +19,10 @@ namespace Microsoft.Toolkit.Collections
     [DebuggerDisplay("Key = {Key}, Count = {Count}")]
     public class ObservableGroup<TKey, TValue> : ObservableCollection<TValue>, IGrouping<TKey, TValue>, IReadOnlyObservableGroup
     {
-        private TKey key;
+        /// <summary>
+        /// The cached <see cref="PropertyChangedEventArgs"/> for <see cref="Key"/>
+        /// </summary>
+        private static readonly PropertyChangedEventArgs KeyChangedEventArgs = new PropertyChangedEventArgs(nameof(Key));
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ObservableGroup{TKey, TValue}"/> class.
@@ -51,6 +54,8 @@ public ObservableGroup(TKey key, IEnumerable<TValue> collection)
             Key = key;
         }
 
+        private TKey key;
+
         /// <summary>
         /// Gets or sets the key of the group.
         /// </summary>
@@ -62,8 +67,8 @@ public TKey Key
                 if (!EqualityComparer<TKey>.Default.Equals(this.key, value))
                 {
                     this.key = value;
-                    
-                    OnPropertyChanged(new PropertyChangedEventArgs(nameof(Key)));
+
+                    OnPropertyChanged(KeyChangedEventArgs);
                 }
             }
         }