Skip to content

Commit

Permalink
Remove redundant code from project files
Browse files Browse the repository at this point in the history
- Remove un-necessary attributes.
- Remove un-used `BinDir` item metadata.
  • Loading branch information
Nirmal4G committed Oct 22, 2022
1 parent 762751e commit e57c9be
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
<None Include="Microsoft.Toolkit.Uwp.Notifications.targets" Pack="true" PackagePath="build\native" />
</ItemGroup>

<!-- In order to support .NET Native, we need to include an appropriate .rd.xml for UWP (remove from everything else) -->

<!-- Desktop Win32 apps -->
<ItemGroup Condition="'$(TargetFramework)' == 'net461' or '$(TargetFramework)' == 'netcoreapp3.1'">
<!-- Reference Windows SDK NuGet of correct target platform version -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,6 @@
<Name>Visual C++ 2015 Runtime for Universal Windows Platform Apps</Name>
</SDKReference>
</ItemGroup>
<ItemGroup />
<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '14.0' ">
<VisualStudioVersion>14.0</VisualStudioVersion>
</PropertyGroup>
Expand Down
5 changes: 0 additions & 5 deletions NuGet.config
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<configuration>
<packageSources>
<clear />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
<add key="AzureLatest" value="https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-MainLatest/nuget/v3/index.json" protocolVersion="3" />
<add key="MUX-Shared" value="https://pkgs.dev.azure.com/ms/microsoft-ui-xaml/_packaging/MUX-Shared/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<clear />
</disabledPackageSources>
</configuration>
1 change: 0 additions & 1 deletion SmokeTests/SmokeTests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@

<ToolkitProject Include="@(ToolkitPackage)">
<Platforms>x86;x64;ARM;ARM64</Platforms>
<BinDir>bin</BinDir>
<AssemblyName>%(ToolkitPackage.Identity)</AssemblyName>
</ToolkitProject>

Expand Down
2 changes: 1 addition & 1 deletion build/Windows.Toolkit.Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@
<ContinuousIntegrationBuild>$(TF_BUILD)</ContinuousIntegrationBuild>
</PropertyGroup>

</Project>
</Project>
4 changes: 0 additions & 4 deletions build/Windows.Toolkit.Common.targets
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
<Project>

<PropertyGroup>
<!-- TODO: Dynamically generate Title if one wasn't set -->
<Title Condition="'$(Title)' == ''">$(Product) Asset</Title>
</PropertyGroup>

<PropertyGroup>
<CommonTags Condition="$(IsCoreProject)">$(CommonTags);.NET</CommonTags>
<CommonTags Condition="$(IsUwpProject)">$(CommonTags);UWP</CommonTags>
<PackageTags Condition="'$(PackageTags)' != ''">$(CommonTags);$(PackageTags)</PackageTags>
Expand Down
1 change: 0 additions & 1 deletion build/Windows.Toolkit.VisualStudio.Design.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<PropertyGroup>
<AppendTargetFrameworkToOutputPath>False</AppendTargetFrameworkToOutputPath>
<AppendRuntimeIdentifierToOutputPath>False</AppendRuntimeIdentifierToOutputPath>
<EmbeddedResourceUseDependentUponConvention>True</EmbeddedResourceUseDependentUponConvention>
<ParentTargetFramework>uap$(TargetPlatformBaseVersion).$(TargetPlatformMinRevision)</ParentTargetFramework>
<ParentProjectName>$(MSBuildProjectName.Remove($(MSBuildProjectName.LastIndexOf('.'))))</ParentProjectName>
</PropertyGroup>
Expand Down

0 comments on commit e57c9be

Please sign in to comment.