Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup based on analyzers #1453

Merged
merged 1 commit into from Aug 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions Microsoft.Toolkit.Services/Core/DataProviderBase.cs
Expand Up @@ -30,7 +30,6 @@ public abstract class DataProviderBase<TConfig>
/// </summary>
public DataProviderBase()
{

}

/// <summary>
Expand Down Expand Up @@ -79,7 +78,7 @@ public static HttpClient HttpClient
get { return httpClient ?? (httpClient = new HttpClient()); }
set { httpClient = value; }
}

/// <summary>
/// Derived classes will have to implement this method to return provider data
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Microsoft.Toolkit.Services/Services/Bing/BingService.cs
Expand Up @@ -53,7 +53,7 @@ protected BingService(BingSearchConfig config)
/// Gets public singleton property.
/// </summary>
public static BingService Instance => instance ?? (instance = new BingService());

/// <summary>
/// Gets a reference to an instance of the underlying data provider.
/// </summary>
Expand Down
Expand Up @@ -20,7 +20,7 @@ namespace Microsoft.Toolkit.Uwp.DeveloperTools
/// <summary>
/// AlignmentGrid is used to display a grid to help aligning controls
/// </summary>
public class AlignmentGrid: ContentControl
public class AlignmentGrid : ContentControl
{
/// <summary>
/// Identifies the <see cref="LineBrush"/> dependency property.
Expand Down Expand Up @@ -73,7 +73,6 @@ public double VerticalStep
set { SetValue(VerticalStepProperty, value); }
}


/// <summary>
/// Initializes a new instance of the <see cref="AlignmentGrid"/> class.
/// </summary>
Expand Down
Expand Up @@ -32,7 +32,7 @@ namespace Microsoft.Toolkit.Uwp.DeveloperTools
[TemplatePart(Name = "ControlType", Type = typeof(TextBlock))]
[TemplatePart(Name = "ControlAutomationName", Type = typeof(TextBlock))]
[TemplatePart(Name = "ControlFirstParentWithName", Type = typeof(TextBlock))]
public class FocusTracker: Control
public class FocusTracker : Control
{
/// <summary>
/// Defines the <see cref="IsActive"/> dependency property.
Expand All @@ -43,7 +43,7 @@ private static void OnIsActiveChanged(DependencyObject d, DependencyPropertyChan
{
var focusTracker = d as FocusTracker;

if (e.NewValue != null && (bool) e.NewValue)
if (e.NewValue != null && (bool)e.NewValue)
{
focusTracker?.Start();
}
Expand All @@ -64,11 +64,8 @@ private static void OnIsActiveChanged(DependencyObject d, DependencyPropertyChan
/// </summary>
public bool IsActive
{
get { return (bool) GetValue(IsActiveProperty); }
set
{
SetValue(IsActiveProperty, value);
}
get { return (bool)GetValue(IsActiveProperty); }
set { SetValue(IsActiveProperty, value); }
}

/// <summary>
Expand All @@ -86,6 +83,7 @@ private void Start()
updateTimer = new DispatcherTimer();
updateTimer.Tick += UpdateTimer_Tick;
}

updateTimer.Start();
}

Expand Down
1 change: 0 additions & 1 deletion Microsoft.Toolkit.Uwp.SampleApp/Properties/AssemblyInfo.cs
Expand Up @@ -25,5 +25,4 @@
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]


[assembly: ComVisible(false)]
Expand Up @@ -25,5 +25,4 @@
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]


[assembly: ComVisible(false)]
Expand Up @@ -64,7 +64,7 @@ internal ColorNode(string paramName, Color value)
}

/// <summary>
/// Performs an implicit conversion from <see cref="Color"/> to <see cref="ColorNode"/>.
/// Performs an implicit conversion from <see cref="T:Color"/> to <see cref="ColorNode"/>.
/// </summary>
/// <param name="value">The value.</param>
/// <returns>The result of the conversion.</returns>
Expand Down
2 changes: 2 additions & 0 deletions UnitTests/Helpers/Test_HttpHelper.cs
Expand Up @@ -24,6 +24,7 @@ public class Test_HttpHelper
[TestMethod]
public async Task Test_HttpHelper_SendRequestAsync()
{
#pragma warning disable CS0612 // Type or member is obsolete
using (var request = new HttpHelperRequest(new Uri("http://dev.windows.com")))
{
using (var response = await HttpHelper.Instance.SendRequestAsync(request))
Expand All @@ -32,6 +33,7 @@ public async Task Test_HttpHelper_SendRequestAsync()
Assert.IsNotNull(response.Content);
}
}
#pragma warning restore CS0612 // Type or member is obsolete
}
}
}
1 change: 0 additions & 1 deletion UnitTests/Properties/AssemblyInfo.cs
Expand Up @@ -26,5 +26,4 @@
[assembly: AssemblyCulture("")]
[assembly: AssemblyMetadata("TargetPlatform", "UAP")]


[assembly: ComVisible(false)]
1 change: 1 addition & 0 deletions UnitTests/UnitTests.csproj
Expand Up @@ -18,6 +18,7 @@
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<PackageCertificateKeyFile>UnitTests_TemporaryKey.pfx</PackageCertificateKeyFile>
<UnitTestPlatformVersion Condition="'$(UnitTestPlatformVersion)' == ''">14.0</UnitTestPlatformVersion>
<PackageCertificateThumbprint>E1D0F2B5EE8606625F7D3B226EEF7B825CCC1A62</PackageCertificateThumbprint>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
Expand Down
Binary file modified UnitTests/UnitTests_TemporaryKey.pfx
Binary file not shown.