Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Toolkit.Mvvm package (part 2) #3413

Merged
12 commits merged into from Aug 11, 2020

Conversation

Sergio0694
Copy link
Member

Follow up to #3229

NOTE

Marking this not as a draft so that the CI will run, but added the "DO NOT MERGE ⚠" tag as we might come up with further improvements to add to this PR before actually deciding to merge this and finalize the package.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)

Notable changes

This PR includes some refinements and tweaks to the Microsoft.Toolkit.Mvvm package, like:

  • Added new ObservableRecipient.SetProperty overloads with Expression<Func<T>> and bool broadcast params
  • Fixed a possible bug in Messenger.Type2.Equals (just to be extra sure)
  • Improved codegen for ObservableRecipient.Set<T>(ref T, T, string) (missing EqualityComparer<T>.Default.Equals inlining)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior improvements ✨ DO NOT MERGE ⚠️ optimization ☄ Performance or memory usage improvements .NET Components which are .NET based (non UWP specific) labels Aug 6, 2020
@ghost
Copy link

ghost commented Aug 6, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost August 6, 2020 12:20
Sergio0694 and others added 2 commits August 11, 2020 18:49
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
@michael-hawker michael-hawker added this to the 7.0 milestone Aug 11, 2020
@ghost
Copy link

ghost commented Aug 11, 2020

Hello @azchohfi!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ff7f24d into CommunityToolkit:master Aug 11, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior improvements ✨ .NET Components which are .NET based (non UWP specific) optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants