Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced AnyCPU on builds. #4151

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Forced AnyCPU on builds. #4151

merged 3 commits into from
Aug 3, 2021

Conversation

azchohfi
Copy link
Contributor

Fixes #4149

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Build fails if the Platform env variable is set to anything other than AnyCPU.

What is the new behavior?

Forces AnyCPU builds on MSBuild calls.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Jul 30, 2021

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and Rosuavio July 30, 2021 21:45
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jul 30, 2021
@Nirmal4G
Copy link
Contributor

Nirmal4G commented Aug 2, 2021

What about non-AnyCPU projects (UWP and App projects), won't they build incorrectly?

@azchohfi
Copy link
Contributor Author

azchohfi commented Aug 2, 2021

@Nirmal4G This is only the Solution configuration, which decides which "row" of the "matrix" that will be used to decide the arch for each project. The UWP projects are still being built as x86, for our tests, for example.

build/build.cake Outdated Show resolved Hide resolved
build/build.cake Show resolved Hide resolved
build/build.cake Show resolved Hide resolved
build/build.cake Show resolved Hide resolved
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
@michael-hawker michael-hawker merged commit 6f8d29f into main Aug 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the anyCpuBuilds branch August 3, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails if Env variable Platform=x64
3 participants