Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls.Media update winui version #4157

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Controls.Media update winui version #4157

merged 1 commit into from
Aug 3, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Aug 3, 2021

Fixes

Update winui version

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Microsoft.Toolkit.Uwp.UI.Controls.Media uses winui 2.5

What is the new behavior?

Microsoft.Toolkit.Uwp.UI.Controls.Media uses winui 2.6.1

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 3, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi August 3, 2021 16:50
@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Aug 3, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Aug 3, 2021
@michael-hawker
Copy link
Member

Thanks @RosarioPulella. I know we already tested these controls as part of the Sample App with the change, so this should just be a build issue to ensure they're being used when the package is alone. So don't expect any problems here once the build is done. 🙂

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Aug 3, 2021

I think the build will fail. Since, we don't yet have the Design project for media controls. I'll add the Design project in #3794, which will make this change work. But for now, just update the WinUI version without the import.

@Rosuavio Rosuavio changed the title Fix missing project import for Controls.Media Controls.Media update winui version Aug 3, 2021
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Aug 3, 2021

Thanks @Nirmal4G, update accordingly.

Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@michael-hawker michael-hawker merged commit 41b0c9a into CommunityToolkit:main Aug 3, 2021
@Rosuavio Rosuavio deleted the winui2.6-missed branch August 3, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
No open projects
Technical 7.1
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants