Fix AttachedDropShadow size changes abnormally #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks chenjt2001 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
the
14 tasks
|
I am not sure whether the sample app needs to be modified. I tested these commits with a simple project (Similar to code in #4548) |
|
The PR fixes the shadow to remain constant when we change the window size |
LalithaNadimpalli
approved these changes
Sep 2, 2022
michael-hawker
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4548
Fix AttachedDropShadow size changes abnormally.
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The mask does not update even if the size of the element that owns the AttachedDropShadow changes.
What is the new behavior?
If the size of the element that owns the AttachedDropShadow changes, the mask will be updated.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information