Ryken100/attached card shadow composition mask brush resize fix #4588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4587
This PR fixes an issue where when
AttachedCardShadow.InnerContentClipType
is set toCompositionMaskBrush
, the shadow doesn't properly resize when the element it's attached to changes size. It also fixes an issue where ifInnerContentClipType
is set toCompositionMaskBrush
then back toCompositionGeometricClip
, resizing gets broken in theCompositionGeometricClip
mode as well.PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
When
AttachedCardShadow.InnerContentClipType == CompositionMaskBrush
, the sizes of the maskedSpriteVisual
, and theSpriteVisual
that owns the shadow were not updated when the attachedFrameworkElement
changes size. Additionally,AttachedShadowElementContext.SpriteVisual.Size
andRelativeSizeAdjustment
values were not reset to default whenInnerContentClipType
changed fromCompositionMaskBrush
toCompositionGeometricClip
.What is the new behavior?
When
AttachedCardShadow.InnerContentClipType == CompositionMaskBrush
, the sizes of the maskedSpriteVisual
, and theSpriteVisual
are now updated when the attachedFrameworkElement
changes size. Additionally,AttachedShadowElementContext.SpriteVisual.Size
andRelativeSizeAdjustment
are reset to default whenAttachedCardShadow.InnerContentClipType == CompositionGeometricClip
, preventing potential resize issues.PR Checklist
Please check if your PR fulfills the following requirements:
Other information