Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source generators should check for cancellation more often #703

Closed
Sergio0694 opened this issue May 16, 2023 · 0 comments · Fixed by #704
Closed

Source generators should check for cancellation more often #703

Sergio0694 opened this issue May 16, 2023 · 0 comments · Fixed by #704
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements

Comments

@Sergio0694
Copy link
Member

Sergio0694 commented May 16, 2023

Overview

Currently, the MVVM Toolkit source generators are propagating the cancellation token in each callback to all calls that need one, but they're not checking for cancellation themselves that much. This can increase overhead when concurrent invocations are triggered, as previous runs of the generators will take longer before they get to a point where they can detect they've been cancelled. We should update them to add more cancellation checks in places that make sense.

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels May 16, 2023
@Sergio0694 Sergio0694 changed the title The MVVM Toolkit source generators should check for cancellation more often Source generators should check for cancellation more often May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant