Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for cancellation more often in generators #704

Merged
merged 1 commit into from May 17, 2023
Merged

Check for cancellation more often in generators #704

merged 1 commit into from May 17, 2023

Conversation

Sergio0694
Copy link
Member

Closes #703

image

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels May 16, 2023
@Sergio0694
Copy link
Member Author

This seems pretty straightfoward, but anything in particular I'm missing to make this even better by any chance? 😄
cc. @Youssef1313

Youssef1313
Youssef1313 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much ThrowIfCancellationRequested 😄 , but LGTM

@Sergio0694 Sergio0694 merged commit 4745ec2 into main May 17, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dev/improve-generator-cancellation branch May 17, 2023 10:19
Sergio0694 added a commit to CommunityToolkit/Labs-Windows that referenced this pull request May 31, 2023
@Sergio0694
Check for cancellation more often in generators
3ef160f 
Same as CommunityToolkit/dotnet#704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
No open projects
8.2.1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source generators should check for cancellation more often
2 participants
@Sergio0694 @Youssef1313