Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PolySharp for polyfills, and centralize shared MSBuild properties #510

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Use PolySharp for polyfills, and centralize shared MSBuild properties #510

merged 5 commits into from
Nov 22, 2022

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Nov 22, 2022 •
edited

This PR uses PolySharp for all polyfills and adds new .props/.targets files.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added the maintenance ⚙️ Some regular maintenance updates label Nov 22, 2022
@Sergio0694 Sergio0694 added this to In progress in 8.1 via automation Nov 22, 2022
@Sergio0694 Sergio0694 merged commit 2edbb0a into main Nov 22, 2022
8.1 automation moved this from In progress to Done Nov 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/shared-props branch November 22, 2022 17:01
@Nirmal4G Nirmal4G mentioned this pull request Nov 24, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance ⚙️ Some regular maintenance updates
Projects
No open projects
8.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sergio0694