Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AV when indexing a sliced Memory2D<T> backed by custom MemoryManager<T> #675

Merged
merged 2 commits into from Apr 27, 2023
Merged

Fix AV when indexing a sliced Memory2D<T> backed by custom MemoryManager<T> #675

merged 2 commits into from Apr 27, 2023

Conversation

Sergio0694
Copy link
Member

Closes #674

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added high-performance 🚂 Issues/PRs for the HighPerformance package bugfix 🔧 PRs fixing a discovered bug labels Apr 27, 2023
@Sergio0694 Sergio0694 changed the title Dev/fix memory2d slicing Fix AV when indexing a sliced Memory2D<T> backed by custom MemoryManager<T> Apr 27, 2023
@Sergio0694 Sergio0694 merged commit 4ad7fef into main Apr 27, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-memory2d-slicing branch April 27, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix 🔧 PRs fixing a discovered bug high-performance 🚂 Issues/PRs for the HighPerformance package
Projects
No open projects
8.2.1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A combination of Cast and Slice leads to AccessViolationException
1 participant
@Sergio0694