Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle [ObservableProperty] fields with keyword identifiers #720

Merged
merged 2 commits into from Jun 21, 2023
Merged

Handle [ObservableProperty] fields with keyword identifiers #720

merged 2 commits into from Jun 21, 2023

Conversation

Sergio0694
Copy link
Member

Closes #710

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug analyzer 👓 A new analyzer being implemented or updated labels Jun 20, 2023
@Sergio0694 Sergio0694 force-pushed the dev/escape-observable-fields branch from 1afa75c to 84476ce Compare June 21, 2023 11:58
@Sergio0694 Sergio0694 merged commit e071ed2 into main Jun 21, 2023
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/escape-observable-fields branch June 21, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
8.2.1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observable Property used on a field with escaped name is not generating correctly
2 participants
@Sergio0694 @Arlodotexe