Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-rails 5.0 support #201

Merged
merged 10 commits into from
Dec 30, 2014
Merged

sass-rails 5.0 support #201

merged 10 commits into from
Dec 30, 2014

Conversation

rmm5t
Copy link
Contributor

@rmm5t rmm5t commented Dec 30, 2014

Closes #198
Closes #195
Closes #197
Closes #194
Closes #191
Closes #192

/cc @danielpclark, @Intrepidd, @hsbt

@josh
Copy link
Contributor

josh commented Dec 30, 2014

GREEN 🎄

craigmcnamara added a commit that referenced this pull request Dec 30, 2014
@craigmcnamara craigmcnamara merged commit 8136aca into Compass:master Dec 30, 2014
@craigmcnamara
Copy link
Member

Awesome!

@josh
Copy link
Contributor

josh commented Dec 30, 2014

I still think we want some version constraints in place since we're going to need to contine testing newer versions of sass-rails and sprockets rails before they are released.

@rmm5t
Copy link
Contributor Author

rmm5t commented Dec 30, 2014

I still think we want some version constraints in place since we're going to need to continue testing newer versions of sass-rails and sprockets rails before they are released.

That's sounds prudent.

@rmm5t rmm5t deleted the sass-rails-5.0 branch December 30, 2014 05:14
@rmm5t rmm5t restored the sass-rails-5.0 branch December 30, 2014 05:14
@danielpclark
Copy link

👍 Awesome! Glad this is coming together. 😄

@dgilperez
Copy link

👏

1 similar comment
@McRip
Copy link

McRip commented Dec 30, 2014

👏

tvdeyen pushed a commit to AlchemyCMS/alchemy_cms that referenced this pull request Jan 2, 2015
Newer versions of compass-rails and sass-rails are not compatible.

See Compass/compass-rails#201 and
linked issues for further info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for sass-rails 5.0.0 patches/sass_importer incorrect method usage
6 participants