Fixed missing prefixes and added non-standard property for moz in column-break mixin #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When emitting the @box properties for flex-direction, setting `box-direction: normal` is almost always unnecessary. Leaving it set to `true` for now so that it doesn't break the tests.
The `box-flex` property from the 2009 draft seems like it lines up better with the modern `flex` property than either `flex-shrink` or `flex-grow`, especially since the @flexbox draft doesn't have `flex-shrink` or `flex-grow` properties.
…eneral Rather than hiding only the `normal` value, I've modified it to always suppress, never suppress, suppress `normal`, or suppress `reverse`.
…ex-legacy-direction` Instead of expressing `$suppress: true`, it is now `$direction: false`. Seems more logical this way. Variable name is more consistent with the other variables in this module.
Conflicts: frameworks/compass/stylesheets/compass/css3/_flexbox.scss test/fixtures/stylesheets/compass/css/flexbox.css
…d property name (addresses #1561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1561.