Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO-2983 Mobile app pay open invoices #1275

Merged
merged 2 commits into from
Feb 4, 2020
Merged

CO-2983 Mobile app pay open invoices #1275

merged 2 commits into from
Feb 4, 2020

Conversation

josueBulle
Copy link
Contributor

No description provided.

Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are flake8 errors as well.

mobile_app_connector/models/account_invoice.py Outdated Show resolved Hide resolved
mobile_app_connector/models/payment_transaction.py Outdated Show resolved Hide resolved
mobile_app_connector/models/payment_transaction.py Outdated Show resolved Hide resolved
mobile_app_connector/tests/test_mobile_account_invoices.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1275 into devel will decrease coverage by 0.24%.
The diff coverage is 10.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1275      +/-   ##
==========================================
- Coverage   53.87%   53.62%   -0.25%     
==========================================
  Files         293      294       +1     
  Lines       15166    15272     +106     
==========================================
+ Hits         8170     8189      +19     
- Misses       6996     7083      +87
Impacted Files Coverage Δ
mobile_app_connector/models/account_invoice.py 9.09% <3.48%> (-10.91%) ⬇️
mobile_app_connector/models/payment_transaction.py 40% <40%> (ø)
crm_compassion/models/interaction_resume.py 55.81% <0%> (-4.19%) ⬇️
crm_compassion/models/res_partner.py 55.88% <0%> (-1.7%) ⬇️
mobile_app_connector/models/mobile_feedback.py 47.16% <0%> (-0.91%) ⬇️
mobile_app_connector/models/wordpress_post.py 32.72% <0%> (-0.61%) ⬇️
cms_form_compassion/models/cms_form.py 27.65% <0%> (-0.55%) ⬇️
mobile_app_connector/models/app_hub.py 73.07% <0%> (-0.37%) ⬇️
sbc_compassion/models/correspondence.py 34.07% <0%> (-0.26%) ⬇️
partner_communication/models/communication_job.py 67.13% <0%> (-0.19%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c3c90...ff72006. Read the comment docs.

Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile_app_connector/models/account_invoice.py:123:45: F812 list comprehension redefines 'l_vals' from line 109
mobile_app_connector/models/account_invoice.py:142:89: E501 line too long (91 > 88 characters)

@ecino ecino merged commit 8da3a8e into CompassionCH:devel Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants