CO-3739 Change OAuth Provider for GMC #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this commit is included in the codebase, the odoo.conf file have to be updated otherwise message to GMC will fail. See related Jira task for modifications to be applied.
ecino
reviewed
Sep 16, 2021
| @@ -124,12 +124,9 @@ def get_gmc_token(cls): | |||
| "connect_token_server in your Odoo configuration file." | |||
| ) | |||
| ) | |||
| params_post = "grant_type=client_credentials&scope=read+write" | |||
| params_post = "grant_type=client_credentials&scope=connect/read-write" | |||
| _logger.error("Please install python jwt") | ||
| raise e |
There was a problem hiding this comment.
If you raise the error we won't be able to run odoo even when the module is not installed I think.
There was a problem hiding this comment.
I though that since communication with the US is a hard requirement, it should be good to let Odoo crash if the requirements are not met instead of letting it run. It's up to you :)
ecino
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this commit is included in the codebase, the odoo.conf file have to
be updated otherwise message to GMC will fail. See related Jira task for
modifications to be applied.