Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate redundancy in read_json #191

Closed
nwlandry opened this issue Oct 5, 2022 · 0 comments · Fixed by #193
Closed

Eliminate redundancy in read_json #191

nwlandry opened this issue Oct 5, 2022 · 0 comments · Fixed by #193
Labels
improve Make an existing feature better

Comments

@nwlandry
Copy link
Collaborator

nwlandry commented Oct 5, 2022

The read_json() function has a lot of the same functionality as dict_to_hypergraph(). We should call the dict_to_hypergraph() method in the read_json() method.
@nwlandry nwlandry added the improve Make an existing feature better label Oct 5, 2022
@nwlandry nwlandry mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improve Make an existing feature better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

simplify read_json xgi-org/xgi
1 participant
@nwlandry