New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize edge "order" and "size" #67
Comments
FWIW, I'd rather keep order so that we don't have problems when implementing simplicial complexes. |
I'm more than OK with order! |
Good point. I'm fine with order too. |
I'm okay with doing this, but will admit that this will be a bit of habit for me to break :). Along these lines, is the biggest remaining change the |
One thing that probably will need to change is that we may not be able to effectively use |
Oh jeez that complicates things. |
Related to #82 |
This was fixed with EdgeStats, no? |
Kind of. We now have both order and size, so any EdgeStat (or any other part of the codebase that is aware of the stats package) can choose which one to use. So on that front we are fine. What has not been addressed is the fact that currently, I guess this particular issue is about the first problem, not the latter, so let's close this. For more discussion of the latter, continue on #82 . |
The words "order" and "size" are used throughout the codebase to refer to the number of nodes in an edge (where order = size-1). I'd suggest we choose one and remove all instances of the other. For example, we have
H.edge_size
butH.edges_of_order
.The text was updated successfully, but these errors were encountered: