Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve http request #261

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Improve http request #261

merged 3 commits into from
Jan 2, 2023

Conversation

nwlandry
Copy link
Collaborator

  • Added an if-else statement to throw an intelligible error if the load_xgi_data request is not successful
  • Added the ability to cache the results of querying XGI-DATA.
  • Changed the default to read=False.
  • Updated contributors.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@nwlandry nwlandry mentioned this pull request Dec 23, 2022
Closed
lordgrilo
lordgrilo approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@lordgrilo lordgrilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support all the comments by @maximelucas and I approve the merge

@nwlandry nwlandry merged commit c3304cb into main Jan 2, 2023
@nwlandry nwlandry deleted the improve-http-request branch January 2, 2023 22:40
@nwlandry nwlandry mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximelucas maximelucas maximelucas left review comments

@lordgrilo lordgrilo lordgrilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nwlandry @lordgrilo @maximelucas