Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning #315

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Fix warning #315

merged 4 commits into from
Apr 1, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Apr 1, 2023

Added a more intelligible warning for sparse adjacency matrix. Fixes #302.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 98.59% and project coverage change: +3.86 🎉

Comparison is base (7d5accb) 86.39% compared to head (cb2866d) 90.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   86.39%   90.26%   +3.86%     
==========================================
  Files          35       35              
  Lines        2757     2814      +57     
==========================================
+ Hits         2382     2540     +158     
+ Misses        375      274     -101     
Impacted Files Coverage Δ
xgi/linalg/matrix.py 98.72% <95.00%> (+4.48%) ⬆️
xgi/classes/reportviews.py 92.07% <100.00%> (ø)
xgi/drawing/draw.py 69.54% <100.00%> (+45.52%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maximelucas
Copy link
Collaborator

Looks good to me, thanks.

@nwlandry nwlandry merged commit e085434 into main Apr 1, 2023
@nwlandry nwlandry deleted the fix-warning branch April 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sparse warning in adjacency matrix
2 participants