Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-2310: Remove CronJob beta API compatibility code #476

Merged
merged 1 commit into from Dec 1, 2023

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Nov 16, 2023

The CronJob API has been stable for a while, and there are no longer any
supported versions of OpenShift that also support the CronJob beta API.

This commit removes the complicated code we needed to ensure the
operator handled clusters with both versions.

The CronJob API has been stable for a while, and there are no longer any
supported versions of OpenShift that also support the CronJob beta API.

This commit removes the complicated code we needed to ensure the
operator handled clusters with both versions.
@openshift-ci-robot
Copy link
Collaborator

@rhmdnd: This pull request references CMP-2310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

The CronJob API has been stable for a while, and there are no longer any
supported versions of OpenShift that also support the CronJob beta API.

This commit removes the complicated code we needed to ensure the
operator handled clusters with both versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd rhmdnd requested review from yuumasato and Vincent056 and removed request for jhrozek November 16, 2023 16:45
@xiaojiey
Copy link
Collaborator

/hold for test

@xiaojiey
Copy link
Collaborator

/unhold
verification pass with 4.15.0-0.nightly-2023-11-19-195637 and 4.11.0-0.nightly-2023-11-17-114901

@xiaojiey
Copy link
Collaborator

/label qe-approved

Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 535aa99 into ComplianceAsCode:master Dec 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants